Stdlib: Reorganize build, test and nix setup #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noteworthy changes: * Stdlib sources are in `stdlib/src` tests are in `stdlib/test` docs are in `stdlib/doc` (no more `rm $out/*Test.mo`) * Individual Makefiles in these directories, as well as the three examples in `stdlib/examples/*` * In `stdlib/tests`, auto-generate a test that simply imports all stdlib files. This makes sure the stdlib actually compiles (was not the case before) * Tests and examples use package imports `"mo:stdlib/…"` to import the stdlib, instead of relative paths. The `Makefile`s are set up to point to `./stdlib/src` by default. But when building via nix, we are building against the stdlib as installed by nix * More fine-grained nix setup, so when you just change the examples, or the tests, the `stdlib` derivation does not have to be rebuild. * Runs the tests for `Rx` and `ActorSpec` using `wasmtimes`
Co-Authored-By: Gabor Greif <[email protected]>
…ko into joachim/stdlib/makefile
ggreif
reviewed
Jan 18, 2020
| $(OUTDIR)/profileFastCounts.csv: test/profileFastCounts.mo | ||
| $(MOC) $(MOC_OPTIONS) -r test/profileFastCounts.mo > $@ | ||
|
|
||
| profile-interp: \ |
There was a problem hiding this comment.
These are nice candidates for patsubst automation. Till the end of the file...
There was a problem hiding this comment.
I didn’t touch this kinda dead code…
There was a problem hiding this comment.
(Also, this PR is identical to #1131 which was already approved :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Resubmission of #1131 with a branch name that doesn’t trip hydra.)
Noteworthy changes:
Stdlib sources are in
stdlib/srctests are in
stdlib/testdocs are in
stdlib/doc(no more
rm $out/*Test.mo)Individual Makefiles in these directories,
as well as the three examples in
stdlib/examples/*In
stdlib/tests, auto-generate a test that simply importsall stdlib files. This makes sure the stdlib actually compiles
(was not the case before)
Tests and examples use package imports
"mo:stdlib/…"to importthe stdlib, instead of relative paths.
The
Makefiles are set up to point to./stdlib/srcby default. Butwhen building via nix, we are building against the stdlib as
installed by nix
More fine-grained nix setup, so when you just change the examples,
or the tests, the
stdlibderivation does not have to be rebuild.Runs the tests for
RxandActorSpecusingwasmtimes