Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: value quota based idl decoder limiting #4657

Merged
merged 51 commits into from
Aug 16, 2024
Merged

feat: value quota based idl decoder limiting #4657

merged 51 commits into from
Aug 16, 2024

Commits on Jul 22, 2024

  1. perf counter based idl decoder limiting

    @crusso
    crusso committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4c48d22 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. meter skip; add test

    @crusso
    crusso committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b7a4df2 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. more tests (some broken?)

    @crusso
    crusso committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7c87222 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. more tests

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8d0e223 View commit details
    Browse the repository at this point in the history

  2. improver earlier tests (reporting cycles)

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    868d7e6 View commit details
    Browse the repository at this point in the history

  3. finish port of tests

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1831132 View commit details
    Browse the repository at this point in the history

  4. assert low cost

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d2cb2d8 View commit details
    Browse the repository at this point in the history

  5. cleanup tests

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4d31ba4 View commit details
    Browse the repository at this point in the history

  6. radical refactoring

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f63dfa8 View commit details
    Browse the repository at this point in the history

  7. update test output, refactr

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    cbb3d0b View commit details
    Browse the repository at this point in the history

  8. don't meter during destabilization

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    7c8955c View commit details
    Browse the repository at this point in the history

  9. up limits

    @crusso
    crusso committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f132d3b View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. fix test values acc to dfinity/candid#564

    @crusso
    crusso committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    e6a75ed View commit details
    Browse the repository at this point in the history

  2. cleanup test; add blurb

    @crusso
    crusso committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    73a8667 View commit details
    Browse the repository at this point in the history

  3. add simulated (idl) perf counter on non-IC targets|

    @crusso
    crusso committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    443d366 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. set up registers just once, including for skipped arguments (tricky b… 

    …ug); modify skip_any_vec to do limit checks
    @crusso
    crusso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    adaea7c View commit details
    Browse the repository at this point in the history

  2. update test output

    @crusso
    crusso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f9a8fdb View commit details
    Browse the repository at this point in the history

  3. Rust formatting

    @crusso
    crusso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    809b5e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. allowing option fields of type Null too, to pass extended candid-tests

    @crusso
    crusso committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    97bea78 View commit details
    Browse the repository at this point in the history

  2. update test output

    @crusso
    crusso committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c15b6e2 View commit details
    Browse the repository at this point in the history

  3. Update rts/motoko-rts/src/idl.rs

    @crusso
    crusso committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7053400 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. test we can decode reasonable binary sizes

    @crusso
    crusso committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b79337c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. set limit as multiple of payload size

    @crusso
    crusso committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9dc5a3c View commit details
    Browse the repository at this point in the history

  2. add test output

    @crusso
    crusso committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7cb0afd View commit details
    Browse the repository at this point in the history

  3. up the limit to 1K

    @crusso
    crusso committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c7d51c5 View commit details
    Browse the repository at this point in the history

  4. add bias term

    @crusso
    crusso committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bcc059c View commit details
    Browse the repository at this point in the history

  5. update bench numbers

    @crusso
    crusso committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ba4c267 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. update idl-sub test to allow optional fields of type Null

    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8ebe1f9 View commit details
    Browse the repository at this point in the history

  2. remove noisy output

    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4279856 View commit details
    Browse the repository at this point in the history

  3. test get/setCandidLimits

    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    06dfcfe View commit details
    Browse the repository at this point in the history

  4. add candid setCandidLimits/getCandidLimits prims to override default … 

    …settings
    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8d19d02 View commit details
    Browse the repository at this point in the history

  5. update bench numbers

    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    cf0a2a8 View commit details
    Browse the repository at this point in the history

  6. update fail test output

    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7014375 View commit details
    Browse the repository at this point in the history

  7. mock setCandidLimits/getCandidLimits in interpreter

    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f27c985 View commit details
    Browse the repository at this point in the history

  8. update test output

    @crusso
    crusso committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0aae079 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. move vec-any-bomb.mo to drun for reliable trap messages

    @crusso
    crusso committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3d0c8f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. just count values

    @crusso
    crusso committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3147631 View commit details
    Browse the repository at this point in the history

  2. use decreasing quota, not increasing counter; optimize zero-sized vec… 

    …tor decoding
    @crusso
    crusso committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0b54e52 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. use 32-bit coefficents, check for zero denominator

    @crusso
    crusso committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    3863e62 View commit details
    Browse the repository at this point in the history

  2. removed redundant tests; update test output

    @crusso
    crusso committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    199d872 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. saturate value_quota on overflow

    @crusso
    crusso committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    01b226b View commit details
    Browse the repository at this point in the history

  2. refactor Registers

    @crusso
    crusso committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fe84142 View commit details
    Browse the repository at this point in the history

  3. fix interpretred getCandidLimits

    @crusso
    crusso committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cbfcdc8 View commit details
    Browse the repository at this point in the history

  4. used u64 for idl_limit_check

    @crusso
    crusso committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9ef3a62 View commit details
    Browse the repository at this point in the history

  5. update test output; merge with mster

    @crusso
    crusso committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0b6eefb View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. update test output

    @crusso
    crusso committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fb9bc85 View commit details
    Browse the repository at this point in the history

  2. check limits before array allocation

    @crusso
    crusso committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    81bccc1 View commit details
    Browse the repository at this point in the history

  3. check array length eagerly in idl_limit_check

    @crusso
    crusso committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f389da8 View commit details
    Browse the repository at this point in the history

  4. Changelog++

    @crusso
    crusso committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7f242d2 View commit details
    Browse the repository at this point in the history

  5. update test output; tweak changelog

    @crusso
    crusso committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fe98b19 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'master' into claudio/candid-metering-count-values

    @crusso
    crusso committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8e07a63 View commit details
    Browse the repository at this point in the history