Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Any back to to_idl_prim, to replace Shared #567

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Add Any back to to_idl_prim, to replace Shared #567

merged 1 commit into from
Jul 15, 2019

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Jul 15, 2019

slipped through the cracks in #560

@nomeata nomeata added the automerge-squash When ready, merge (using squash) label Jul 15, 2019
@nomeata nomeata requested a review from rossberg July 15, 2019 10:31
rossberg
rossberg approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry about that.

@mergify mergify bot merged commit 01dd5c1 into master Jul 15, 2019
@mergify mergify bot deleted the joachim/typedesc-any branch July 15, 2019 11:18
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jul 15, 2019
@nomeata
Copy link
Collaborator Author

nomeata commented Jul 15, 2019

No problem.

dfinity-bot added a commit that referenced this pull request Jun 11, 2023
@dfinity-bot
niv motoko-base: update fbae09e4 -> 494480ac
b3d231c 
## Changelog for motoko-base:
Branch: next-moc
Commits: [dfinity/motoko-base@fbae09e4...494480ac](dfinity/motoko-base@fbae09e...494480a)

* [`414150da`](dfinity/motoko-base@414150d) Motoko 0.9.2
* [`6bea7441`](dfinity/motoko-base@6bea744) Blob.compare: Use new blob comparison prim ([dfinity/motoko-base⁠#567](https://togithub.com/dfinity/motoko-base/issues/567))
mergify bot pushed a commit that referenced this pull request Jun 11, 2023
@dfinity-bot
niv motoko-base: update fbae09e4 -> 494480ac (#4032)
4356e11 
## Changelog for motoko-base:
Branch: next-moc
Commits: [dfinity/motoko-base@fbae09e4...494480ac](dfinity/motoko-base@fbae09e...494480a)

* [`414150da`](dfinity/motoko-base@414150d) Motoko 0.9.2
* [`6bea7441`](dfinity/motoko-base@6bea744) Blob.compare: Use new blob comparison prim ([dfinity/motoko-base⁠#567](https://togithub.com/dfinity/motoko-base/issues/567))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossberg rossberg rossberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nomeata @rossberg