update to .NET Standard 2.0 DLL for EPPlus #1604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardmiller-mesirow
force-pushed
the
epplus-netstandard2.0
branch
from
1b88ed0
to
2697dc9
Compare
edwardmiller-mesirow
force-pushed
the
epplus-netstandard2.0
branch
from
2697dc9
to
2e54cd3
Compare
edwardmiller-mesirow
force-pushed
the
epplus-netstandard2.0
branch
from
2e54cd3
to
01d8b42
Compare
|
Why did you close? |
|
@dfinke The tests were failing and I wasn't sure why. So I guess I'm giving up on this one for now. I personally didn't see a very noticeable performance benefit with my local manual test that I ran. Was also considering using a step to pull these DLLs down from NuGet or something, instead of cluttering the repository with binary blobs. So I don't really like this PR very much right now even if it were working. If you want to re-open and work on it, that's cool. |
|
Thanks for looking into that. It is a single DLL that is why I put it in the repo. Didn't want to support another set of moving parts. Yeah, the EPPlus folks did a great job on it and deserve to get paid for they decade+ work. Wish we could use the new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last version of the LGPL version of EPPlus was 4.5.3.3 and targets .NET Standard 2.0 (and .NET Standard 2.1)
The version currently on the master branch is 4.5.3.2 targeting .NET Framework 4
.NET Standard 2.0 supports .NET Framework 4.6 and above. Anything older is out of support anyways.
Ideally using .NET Standard 2.1 where possible would be even better.
Using .NET Standard 2.0+ could potentially allow newer APIs to be leveraged for EPPlus and thus improve performance.
I ran preliminary tests locally and it worked ok, as long as all the transitive dependencies were included as well.
https://www.nuget.org/packages/EPPlus/4.5.3.3