Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ts2date #4

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Feature/ts2date #4

merged 12 commits into from
Sep 25, 2023

Conversation

Bitbee0
Copy link
Contributor

@Bitbee0 Bitbee0 commented Sep 18, 2023

No description provided.

@Bitbee0 Bitbee0 added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2023
src/bin/ts2date/main.rs Outdated Show resolved Hide resolved
src/bin/ts2date/main.rs Outdated Show resolved Hide resolved
Comment on lines 4 to 6
pub trait UnixTimestamp {
fn ts2date(ts: i64) -> String;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer something like the following

Suggested change
pub trait UnixTimestamp {
fn ts2date(ts: i64) -> String;
}
pub trait ForensicsTimestamp {
fn ts2date(&self) -> String;
}

Copy link
Member

@janstarke janstarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions. We can discuss them if you would like to

Bitbee0 and others added 3 commits September 22, 2023 12:13
…overwrited 'format_date' in 'Mactime2Application')
@janstarke janstarke merged commit 5d6ec85 into master Sep 25, 2023
1 check passed
@janstarke janstarke deleted the feature/ts2date branch September 25, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants