Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import of is_prng_key #27

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Change import of is_prng_key #27

merged 3 commits into from
Jan 24, 2024

Conversation

adrn
Copy link
Contributor

@adrn adrn commented Jan 24, 2024

I'm getting a DeprecationWarning from using numpyro.distributions.util.is_prng_key():

Example:

python -W "default::DeprecationWarning" -c "from numpyro.distributions.util import is_prng_key; is_prng_key(42)"

It looks like it was moved in this PR:
pyro-ppl/numpyro#1642

This would require numpyro>=0.13.1 https://github.com/pyro-ppl/numpyro/releases/tag/0.13.1 -- do you want me to add some backwards compatibility here? Or add the numpyro version constraint?

@dfm
Copy link
Owner

dfm commented Jan 24, 2024

Thanks! Let's update the numpyro version constraint. I don't think we need to maintain too much backwards compatibility!

@adrn
Copy link
Contributor Author

adrn commented Jan 24, 2024

Hm, I'm guessing the 3.8 build is failing because the recent numpyro depends on a newer version of jax that requires python >= 3.9 (https://pypi.org/project/jax/0.4.14/) -- I'll update the min python version but let me know if you prefer a different solution!

@dfm
Copy link
Owner

dfm commented Jan 24, 2024

Please do!

@adrn
Copy link
Contributor Author

adrn commented Jan 24, 2024

Done in the last commit!

@dfm dfm merged commit 63b0568 into dfm:main Jan 24, 2024
9 checks passed
@dfm
Copy link
Owner

dfm commented Jan 24, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants