Added the ability to set xml2js options. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, I wanted the ability to set `{explicitArray: false}` in the xml2js parameters. This eliminates the need for the constant `[0]` and generally makes the objects returned from amazon much nicer looking. I would have suggested making it default if it wouldn't break backwards compatibility.
|
There is the matter of arrays showing up as objects (in the event that they only have 1 element) but I'd rather run anything expected to be an array through |
neshte
added a commit
to jokenson/mws-sdk
that referenced
this pull request
Jan 10, 2018
Addition of params parameter to request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, I wanted the ability to set
{explicitArray: false}in the xml2js parameters. This eliminates the need for the constant[0]and generally makes the objects returned from amazon much nicer looking. I would have suggested making it default if it wouldn't break backwards compatibility.