Real-space cutoffs

[marvinfriede]

Real-space cutoffs for the coordination number and the dispersion energy are implemented to (finally) achieve full consistency with the total dispersion energy of the Fortran implementation.

[awvwgk]

Let's provide all cutoff values in the constructor rather than having to construct an incomplete object and adding the attributes with setters.

Also, no C-style casting in C++.

[marvinfriede]

Let's provide all cutoff values in the constructor rather than having to construct an incomplete object and adding the attributes with setters.

I don't understand that part. The constructor writes the default values to all members here. The setters are just for changing it (required within a test).

Also, no C-style casting in C++.

So just multiplying by 1.0?

[awvwgk]

I don't understand that part. The constructor writes the default values to all members here. The setters are just for changing it (required within a test).

Why not have the tests recreate the object with the correct values in the constructor then? Or directly setting the value of the members as they are public.

So just multiplying by 1.0?

https://en.cppreference.com/w/cpp/language/static_cast

[marvinfriede]

I don't understand that part. The constructor writes the default values to all members here. The setters are just for changing it (required within a test).

Why not have the tests recreate the object with the correct values in the constructor then? Or directly setting the value of the members as they are public.

Oh. I forgot about the members being public...

[marvinfriede]

Can I merge this?