Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize project #479

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Dockerize project #479

merged 3 commits into from
Oct 19, 2021

Conversation

ccamel
Copy link
Contributor

@ccamel ccamel commented Oct 18, 2021

@dgarijo here's the dockerfile for building a docker image of Widoco as discussed in #467. Just let me know if you have any comments.

(by the way, I think it would be nice to have a bit of continuous integration, to make sure the docker image builds correctly)

@ccamel
Copy link
Contributor Author

ccamel commented Oct 18, 2021

@dgarijo do you want me to add a section about that in the README.md?

@dgarijo
Copy link
Owner

dgarijo commented Oct 18, 2021

@ccamel thanks a lot! Please do, if possible explaining how to use it using a volume. Also, add yourself as a collaborator in the readme, please.

Do you know if this image incorporates a server? I think we could have a script for serving the generated doc

@dgarijo
Copy link
Owner

dgarijo commented Oct 19, 2021

Oh, also please do the pull request against develop, not master.

@ccamel ccamel changed the base branch from master to develop October 19, 2021 15:31
@ccamel
Copy link
Contributor Author

ccamel commented Oct 19, 2021

@dgarijo I've pushed some changes.

Do you know if this image incorporates a server? I think we could have a script for serving the generated doc

Well, the image (openjdk:17-slim) does not come with a web server, but we could easily add it if needed.

@dgarijo
Copy link
Owner

dgarijo commented Oct 19, 2021

ok, let's test this one first and then we can refine. Thanks!!

@dgarijo dgarijo merged commit 1f2d965 into dgarijo:develop Oct 19, 2021
@ccamel ccamel deleted the dockerization branch October 20, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants