Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename output directory with lowercase #498

Closed
wants to merge 1 commit into from
Closed

Rename output directory with lowercase #498

wants to merge 1 commit into from

Conversation

engapa
Copy link
Contributor

@engapa engapa commented Jan 19, 2022 •
edited
Loading

Solves Docker build error (copy from "jar" instead of "JAR") #499

@dgarijo
Copy link
Owner

dgarijo commented Jan 19, 2022

@engapa,
thanks for catching this. I have tried this image without issues, I don't know how I missed this.
Can you please:

  • Push your changes to the Docker image instead of the POM?
  • Push your changes to the develop branch?
    Thanks in advance!

@engapa
Copy link
Contributor Author

engapa commented Jan 19, 2022

ok, perfect!

engapa added a commit to engapa/Widoco that referenced this pull request Jan 19, 2022
@engapa
Fix dgarijo#498
b9c1291
@engapa engapa mentioned this pull request Jan 19, 2022
Merged
@engapa engapa closed this Jan 19, 2022
dgarijo added a commit that referenced this pull request Jan 19, 2022
@dgarijo
Merge pull request #500 from engapa/develop
0ea663e 
Fix #498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engapa @dgarijo