Copy resources directly without zip #653
Conversation
|
@vChavezB thanks! Can you please merge in |
|
I have changed it to the develop branch. Should I also delete the webvowl patched zip and display the source files ? At the moment I tested my changes only with the resources from the folder loder and oops. |
|
We should be consistent, so yes, if it's not a lot of effort, let's do that. Having to create the zip file every time is less ideal. |
vChavezB
force-pushed
the
copy-direct-resources
branch
from
fed3e06
to
ba89c6b
Compare
|
updated 👍 |
|
This looks good to me. I'll have to check if those |
|
Ouch, no, it does not pass the tests. I will leave a few comments where the errors may be |
|
Thanks for the feedback. I think I did not push the changes for those files correctly. Will have a look again ;) |
vChavezB
force-pushed
the
copy-direct-resources
branch
from
ba89c6b
to
a365dbd
Compare
|
Still not :( |
|
Sorry for the multiple changes. I must admit that Java is not my first language. I will do a clean git clone and compile again to debug this. |
|
No rush |
Instead of using zip files, use the source files in the resources directory. This allows to track differences easily over git as zip files cannot be compared between commits easily.
vChavezB
force-pushed
the
copy-direct-resources
branch
from
a365dbd
to
3ee9c26
Compare
|
Ok I think it should now compile, for some reason the previous commit did not use the |
|
Thanks, looking good. Will review and merge soon! |
Instead of using zip files, use the source files in the resources directory. This allows to track differences easily over git as zip files cannot be compared between commits easily.
In specific I did this as I am testing the swrl rules xslt files (see #652 ) and found out that the zip file is used instead of the
src/main/resources/lodefolder.