Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run widoco with unprivileged user in container #669

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

janvlug
Copy link
Contributor

@janvlug janvlug commented Jan 4, 2024

  • The container runs WIDOCO now as an unprivileged user
  • Example works now also with SELinux

@dgarijo
Copy link
Owner

dgarijo commented Jan 5, 2024

For some reason this does not pass all the tests. I do not understand, since it does not modify the code at all...

@vChavezB
Copy link
Contributor

vChavezB commented Jan 5, 2024

The error occured with the testOntologyFromURL. Perhaps an anomaly happened while retrieving the ontology from the url. Maybe just run the pipeline again?

@janvlug
Copy link
Contributor Author

janvlug commented Jan 5, 2024

I'm also surprised by the failing tests. Maybe indeed an anomaly when retrieving the URL. Locally the tests run successfully for me. Is there a way to trigger the tests on GitHub again? Or should I close this Pull request and try to create a new one, and see if the test will succeed then?

@vChavezB
Copy link
Contributor

vChavezB commented Jan 5, 2024

You could force trigger the pipeline by adding an ammended commit.

git commit --amend

do not change the commit message and then

git push origin --force

Not the nicest way but this way you can retrigger the github actions by making github detect the "new" commit.

@dgarijo
Copy link
Owner

dgarijo commented Jan 5, 2024

No need to close the PR. I think it's just fine because the code was not changed. Merging

@dgarijo dgarijo merged commit b536685 into dgarijo:master Jan 5, 2024
3 of 4 checks passed
@dgarijo
Copy link
Owner

dgarijo commented Jan 5, 2024

Just next time please do PRs into develop. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants