Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConfigParser instead of SafeConfigParser #208

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

hongxu-jia
Copy link
Contributor

The SafeConfigParser class will be renamed to ConfigParser in Python 3.12 [1]. This alias will be removed in future versions.So we can use ConfigParser directly instead.

[1] python/cpython#89336

Signed-off-by: Hongxu Jia [email protected]

Description

Provide a brief description of the PR's purpose here.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • TODO 1

Questions

  • Question1

Status

  • Ready to go

The SafeConfigParser class will be renamed to ConfigParser in Python
3.12 [1]. This alias will be removed in future versions.So we can use
ConfigParser directly instead.

[1] python/cpython#89336

Signed-off-by: Hongxu Jia <[email protected]>
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #208 (0beacf9) into master (4c7eb61) will not change coverage.
The diff coverage is n/a.

Copy link
Owner

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, fortunately this call is rendered out when a package was built and will not effect a package.

@dgasmith dgasmith merged commit 7c8f193 into dgasmith:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants