Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go health report warnings. #773

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Fix go health report warnings. #773

merged 1 commit into from
Apr 19, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Apr 19, 2019 •
edited by manishrjain
Loading

This change is Reviewable

jarifibrahim
jarifibrahim approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jarifibrahim
Copy link
Contributor

The build failures are not related to this PR. They're because of dgryski/go-farm#17 and #769.

@jarifibrahim jarifibrahim merged commit 1fcc96e into master Apr 19, 2019
@jarifibrahim jarifibrahim deleted the martinmr/fix-warnings branch April 19, 2019 12:58
@jarifibrahim jarifibrahim restored the martinmr/fix-warnings branch April 19, 2019 12:59
@ashish-goswami ashish-goswami deleted the martinmr/fix-warnings branch April 19, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim jarifibrahim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmr @jarifibrahim