fix(pool): use write lock when getting health info (#7963)

conn/pool.go

@@ -344,10 +344,11 @@ func (p *Pool) IsHealthy() bool {
 
 // HealthInfo returns the healthinfo.
 func (p *Pool) HealthInfo() pb.HealthInfo {
-	p.RLock()
-	defer p.RUnlock()
+	ok := p.IsHealthy()
+	p.Lock()
+	defer p.Unlock()
 	p.healthInfo.Status = "healthy"
-	if !p.IsHealthy() {
+	if !ok {
 		p.healthInfo.Status = "unhealthy"
 	}
 	p.healthInfo.LastEcho = p.lastEcho.Unix()

worker/groups.go

@@ -58,6 +58,7 @@ type groupi struct {
 var gr = &groupi{
 	blockDeletes: new(sync.Mutex),
 	tablets:      make(map[string]*pb.Tablet),
+	closer:       z.NewCloser(3), // Match CLOSER:1 in this file.
 }
 
 func groups() *groupi {
@@ -155,7 +156,6 @@ func StartRaftNodes(walStore *raftwal.DiskStorage, bindall bool) {
 	gr.Node.InitAndStartNode()
 	glog.Infof("Init and start Raft node: OK")
 
-	gr.closer = z.NewCloser(3) // Match CLOSER:1 in this file.
 	go gr.sendMembershipUpdates()
 	go gr.receiveMembershipUpdates()
 	go gr.processOracleDeltaStream()