Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize bulk and live loader #2927

Closed
codexnull opened this issue Jan 23, 2019 · 0 comments
Closed

Harmonize bulk and live loader #2927

codexnull opened this issue Jan 23, 2019 · 0 comments
Assignees
@codexnull
Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.

Comments

@codexnull
Copy link
Contributor

From a user's perspective, dgraph bulk and dgraph load are two commands that do the same thing: load external data onto the database.

Users, then, might expect that they can used the same way. Command line options that do the same thing should have the same name, options that have the same name should do the same thing, etc.

Internally, both commands should also use the same code whenever possible instead of having two implementations.
@codexnull codexnull self-assigned this Jan 23, 2019
@codexnull codexnull added the kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. label Jan 23, 2019
@codexnull codexnull mentioned this issue Feb 1, 2019
Merged
codexnull added a commit that referenced this issue Feb 6, 2019
@codexnull
Live & bulk loader changes (#2961)
bcc7796 
Fixes #2889, #2927.

Summary of loader changes:

    * Support live loading JSON files

    * Support loading RDF or JSON stream instead of requiring files in live loader

    * Auto-detect compressed load data instead of requiring extension in filename in both loaders

    * Auto-detect JSON load data instead of requiring extension in filename in both loaders

    * Lots of refactoring of live and bulk loaders to share code for the same functionality
dna2github pushed a commit to dna2fork/dgraph that referenced this issue Jul 19, 2019
@codexnull @dna2github
Live & bulk loader changes (dgraph-io#2961)
a323fdd 
Fixes dgraph-io#2889, dgraph-io#2927.

Summary of loader changes:

    * Support live loading JSON files

    * Support loading RDF or JSON stream instead of requiring files in live loader

    * Auto-detect compressed load data instead of requiring extension in filename in both loaders

    * Auto-detect JSON load data instead of requiring extension in filename in both loaders

    * Lots of refactoring of live and bulk loaders to share code for the same functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codexnull codexnull

Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codexnull