Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Residual predicates with RDF export endpoint #5053

Closed
mehdiym opened this issue Mar 29, 2020 · 2 comments · Fixed by #5302
Closed

Residual predicates with RDF export endpoint #5053

mehdiym opened this issue Mar 29, 2020 · 2 comments · Fixed by #5302
Assignees
@jarifibrahim
Labels
priority/P3 Low priority, something to be done once everything else seems fixed. status/accepted We accept to investigate/work on it.

Comments

@mehdiym
Copy link

mehdiym commented Mar 29, 2020

What version of Dgraph are you using?

1.2.2 and master 46dfaab

Steps to reproduce the issue (command/config used to run Dgraph).

  • On ratel, drop some predicates
  • Query the "/admin/export" endpoint

Expected behaviour and actual result.

  • Edit the g01.schema generated file
  • The dropped predicates should be gone but they are not
  • Their indexes has been removed though, they are now set as default

I checked the generated g01.rdf.gz, and there is no n-quad with those removed predicates.
@pawanrawal
Copy link
Contributor

pawanrawal commented Apr 16, 2020 •
edited
Loading

I have been able to reproduce the issue. After dropping a predicate, its schema type is changed to default and when an export is done we can see that the predicate is there in the schema file with default type. This is not a big problem because the user can insert new data for the predicate with a new schema type, but still it would be nice to not have the predicate be part of the exported schema after it is dropped.

@pawanrawal pawanrawal added status/accepted We accept to investigate/work on it. priority/P3 Low priority, something to be done once everything else seems fixed. labels Apr 16, 2020
@jarifibrahim jarifibrahim self-assigned this Apr 21, 2020
@jarifibrahim jarifibrahim mentioned this issue Apr 27, 2020
Merged
jarifibrahim pushed a commit that referenced this issue Apr 29, 2020
Export: Ignore deleted predicates from schema (#5302)
23140a9 
Fixes #5053
Fixes DGRAPH-1260

The current implementation of export would add dropped
predicates and deleted types to the exported schema.
This PR fixes it by ignoring the deleted predicates and types.
jarifibrahim pushed a commit that referenced this issue Apr 29, 2020
Export: Ignore deleted predicates from schema (#5302)
34541f2 
Fixes #5053
Fixes DGRAPH-1260

The current implementation of export would add dropped
predicates and deleted types to the exported schema.
This PR fixes it by ignoring the deleted predicates and types.

(cherry picked from commit 23140a9)
jarifibrahim pushed a commit that referenced this issue Apr 29, 2020
Export: Ignore deleted predicates from schema (#5302)
d5221e4 
Fixes #5053
Fixes DGRAPH-1260

The current implementation of export would add dropped
predicates and deleted types to the exported schema.
This PR fixes it by ignoring the deleted predicates and types.

(cherry picked from commit 23140a9)
This was referenced Apr 29, 2020
Merged
Merged
@jarifibrahim
Copy link
Contributor

Hey @mehdiym, this issue has been fixed in the master branch. Please do give it a try and let me know how it goes.

jarifibrahim pushed a commit that referenced this issue May 4, 2020
Export: Ignore deleted predicates from schema (#5302) (#5326)
7193f47 
Fixes #5053
Fixes DGRAPH-1260

The current implementation of export would add dropped
predicates and deleted types to the exported schema.
This PR fixes it by ignoring the deleted predicates and types.

(cherry picked from commit 23140a9)
jarifibrahim pushed a commit that referenced this issue May 4, 2020
Export: Ignore deleted predicates from schema (#5302) (#5327)
565ec55 
Fixes #5053
Fixes DGRAPH-1260

The current implementation of export would add dropped
predicates and deleted types to the exported schema.
This PR fixes it by ignoring the deleted predicates and types.

(cherry picked from commit 23140a9)
dna2github pushed a commit to dna2fork/dgraph that referenced this issue Jul 18, 2020
@dna2github
Export: Ignore deleted predicates from schema (dgraph-io#5302)
57c7ba2 
Fixes dgraph-io#5053
Fixes DGRAPH-1260

The current implementation of export would add dropped
predicates and deleted types to the exported schema.
This PR fixes it by ignoring the deleted predicates and types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarifibrahim jarifibrahim

Labels
priority/P3 Low priority, something to be done once everything else seems fixed. status/accepted We accept to investigate/work on it.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export: Ignore deleted predicates from schema dgraph-io/dgraph
3 participants
@mehdiym @pawanrawal @jarifibrahim