Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set glog flags from configuration #3062

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Set glog flags from configuration #3062

merged 3 commits into from
Feb 26, 2019

Commits on Feb 25, 2019

  1. Set glog flags from configuration 

    This PR fixes dgraph-io#2854

Why glog can't use values set in config file?
glog reads values from flags. When a user sets the value (of a glog flag) in a config file, glog doesn't recognize it because the flag value hasn't changed.

How does this PR fix it?
With this PR, we set the value of glog flags from the values in config file.
Note: This is a hack. glog doesn't allow setting configuration programatically and thus we have to use this hack.

Signed-off-by: Ibrahim Jarif <[email protected]>
    @jarifibrahim
    jarifibrahim committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    3495db7 View commit details
    Browse the repository at this point in the history

  2. Fix error check 

    Signed-off-by: Ibrahim Jarif <[email protected]>
    @jarifibrahim
    jarifibrahim committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    e0f4143 View commit details
    Browse the repository at this point in the history

  3. Fix line length 

    Signed-off-by: Ibrahim Jarif <[email protected]>
    @jarifibrahim
    jarifibrahim committed Feb 25, 2019
    Configuration menu
    Copy the full SHA
    8020362 View commit details
    Browse the repository at this point in the history