Limit num pending proposals in apply channel #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnel to prevent OOM.
danielmai
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
manishrjain
added a commit
that referenced
this pull request
Apr 30, 2019
Add a ramp meter to avoid pushing too many big proposals to apply channel to prevent OOM. Changes: * Apply ramp meter before considering current proposal * Add a log to warn if pending proposals exceeds the limit by two.
codexnull
reviewed
Apr 30, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain)
worker/draft.go, line 490 at r1 (raw file):
} if sz := atomic.AddInt64(&n.pendingSize, -totalSize); sz < 0 { glog.Warningf("Pending size should remain above zero: %d", sz)
Is it harmless for the pending size to be below zero or does it indicate a more serious logic error somewhere?
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Add a ramp meter to avoid pushing too many big proposals to apply channel to prevent OOM. Changes: * Apply ramp meter before considering current proposal * Add a log to warn if pending proposals exceeds the limit by two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a ramp meter to avoid pushing too many big proposals to apply channel to prevent OOM.
This change is