Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick diff snapshot change into release/v1.0 #3454

Merged
merged 2 commits into from
May 21, 2019
Merged

Cherry-pick diff snapshot change into release/v1.0 #3454

merged 2 commits into from
May 21, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented May 21, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@martinmr martinmr requested a review from manishrjain May 21, 2019 19:07
manishrjain
manishrjain approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 6e4b47b into release/v1.0 May 21, 2019
@martinmr martinmr deleted the martinmr/cp-diff-snapshot-v2 branch May 21, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinmr @manishrjain