Set default type predicates as lists. #3792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If users add multiple entries to predicates of default type, the current behavior is to overwrite existing values. This can lead to data loss in cases where users didn't intend to do that or forgot to set a schema for the predicate beforehand. This change makes it so that predicates of default type are created as lists.
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@martinmr you can click here to see the review status or cancel the code review job.
|
I think I need this to load the arango benchmark data without having to figure out the schema (I don't think any of their benchmarks care about the schema). |
|
Doesn't work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users add multiple entries to predicates of default type, the current
behavior is to overwrite existing values. This can lead to data loss in
cases where users didn't intend to do that or forgot to set a schema for
the predicate beforehand.
This change makes it so that predicates of default type are created as
lists.
Fixes #3788
This change is