Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about changes introduced by PR #4531 #4591

Merged
merged 2 commits into from
Jan 20, 2020

Conversation

animesh2049
Copy link
Contributor

@animesh2049 animesh2049 commented Jan 16, 2020

Now we allow filtering based on non-idexed predicate for comparision functions.


This change is Reviewable

@sleto-it
Copy link
Contributor

sleto-it commented Jan 16, 2020

Hi, one comment from me. In general, it would be extremely useful, when something changes or is a totally new feature, that we document the version when the change happened or when the feature was introduced

Examples for new features:

a) [...]. This option has been introduced in vX.Y
b) Starting from vX.Y, it is now possible to [...]

Examples for changes:

a) Beginning with vX.Y, [...]. Previously {quick description of old behavior)

This will help a lot both users and support team

Examples / reference (from MySQL and MongoDB):

1. https://dev.mysql.com/doc/refman/8.0/en/with.html

Screen Shot 2020-01-16 at 2 31 49 PM

2. https://dev.mysql.com/doc/refman/8.0/en/comparison-operators.html

Screen Shot 2020-01-16 at 2 34 30 PM

3. https://docs.mongodb.com/manual/reference/method/db.getLastErrorObj/

Screen Shot 2020-01-16 at 2 43 18 PM

Thanks,

Copy link
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @animesh2049, @campoy, @danielmai, and @MichaelJCompton)


wiki/content/query-language/index.md, line 217 at r1 (raw file):

Comparison functions in the query root (aka func:) can only be applied on [indexed predicates]({{< relref "#indexing">}}).
Since v1.2, comparison functions can now be used on @filter directives even on predicates that have not been indexed.
Filtering on non-indexed predicates can be slow for large datasets, as they require iterating over all of the possible values at the level where the filter is being used.

And add a bunch fo links to "query root", "filter", etc

Not sure this needs to be inside of a notice, though ... maybe on the notice just add "Support for filters on non-indexed predicates was added with Dgraph v1.2.0" and let the explanation above right after.

Copy link
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @animesh2049, @danielmai, and @MichaelJCompton)

Copy link
Contributor

@campoy campoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @animesh2049, @danielmai, and @MichaelJCompton)

@animesh2049 animesh2049 merged commit 4653274 into master Jan 20, 2020
@animesh2049 animesh2049 deleted the animesh2049/docs-changes branch January 20, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants