fix(flags): Convert numbers correctly in SuperFlags #7712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeetdsouza
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
ajeetdsouza
changed the title
danielmai
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)
mangalaman93
pushed a commit
that referenced
this pull request
Aug 10, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 10, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 10, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 16, 2023
mangalaman93
added a commit
that referenced
this pull request
Aug 16, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large JSON integers are not being printed correctly (since JSON doesn't have an actual integer type). This PR provides a best-effort way to convert from JSON floats to SuperFlag integers.
This change is