fix(Chunker): don't delete node with empty facet in mutation #7737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlmcguire
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
manishrjain
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @vvbalaji-dgraph)
karlmcguire
commented
Apr 22, 2021
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status:
karlmcguire
added a commit
that referenced
this pull request
Apr 22, 2021
* don't delete node with empty facet mutation * documentation * add note to get CI passing
karlmcguire
added a commit
that referenced
this pull request
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for this issue found on Friday.
Postmortem
map[string]interface{}to a separate map for a performance boost.buf.checkForDeletionfunction we don't account for facet keys removed from the main map.{"uid":1000,"doesnt|exist":null}essentially gets turned into{"uid":1000}before it reachesbuf.checkForDeletion, and since it's aDeleteNquadsoperation, it deletes the entire node.Fix
mapResponse.buf.checkForDeletionshould now behave as it did before fix(Chunker): JSON parsing performance #7171.Let me know if this could introduce any other issues, or anything else I should add to the Chunker tests.
This change is