Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(graphql): Fix error message of lambdaOnMutate directive #7751

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fix(graphql): Fix error message of lambdaOnMutate directive #7751

merged 1 commit into from
Apr 26, 2021

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Apr 26, 2021 •
edited by manishrjain
Loading

When posting a schema that uses the @lambdaOnMutate directive, this error comes up:

{"errors":[{"message":"resolving updateGQLSchema failed because input:1: Type Author: has the @lambdaOnMutate directive, but the –graphql_lambda_url flag wasn't specified during alpha startup.\n (Locations: [{Line: 3, Column: 4}])","extensions":{"code":"Error"}}]}(base)

But when we start alpha with the suggested flag, we get:

./dgraph alpha --graphql_lambda_url http://127.0.0.1:8686
Error: unknown flag: --graphql_lambda_url

This PR fixes the error message.

This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Apr 26, 2021
@ahsanbarkati ahsanbarkati merged commit eb7dc76 into master Apr 26, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/lambda_url_error branch April 26, 2021 07:07
ahsanbarkati added a commit that referenced this pull request Apr 26, 2021
@ahsanbarkati
Fix(graphql): Fix error message of lambdaOnMutate directive (#7751)
754ee8f 
The error message used to contain `--graphql_lambda_url" flag.
This flags has been deprecated. This change fixes the error
message of lambdaOnMutate directive to contain superflag.

(cherry picked from commit eb7dc76)
ahsanbarkati added a commit that referenced this pull request Apr 26, 2021
@ahsanbarkati
Fix(graphql): Fix error message of lambdaOnMutate directive (#7751) (#…
aae5a40 
…7754)

The error message used to contain `--graphql_lambda_url" flag.
This flags has been deprecated. This change fixes the error
message of lambdaOnMutate directive to contain superflag.

(cherry picked from commit eb7dc76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamanJain8 NamanJain8 NamanJain8 approved these changes

@pawanrawal pawanrawal Awaiting requested review from pawanrawal

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsanbarkati @NamanJain8