Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graphql): fixing query timeouts for graphql queries too #7796

Merged
merged 2 commits into from
May 10, 2021

Conversation

aman-bansal
Copy link
Contributor

@aman-bansal aman-bansal commented May 9, 2021


This change is Reviewable

@@ -1102,6 +1102,16 @@ func getAuthMode(ctx context.Context) AuthMode {
// QueryGraphQL handles only GraphQL queries, neither mutations nor DQL.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this comments is still valid. Please check and suggest should I fix this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is still valid.

@@ -1102,6 +1102,16 @@ func getAuthMode(ctx context.Context) AuthMode {
// QueryGraphQL handles only GraphQL queries, neither mutations nor DQL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is still valid.

@aman-bansal aman-bansal merged commit bb0358e into release/v21.03-slash May 10, 2021
@aman-bansal aman-bansal deleted the aman/fix_gql_timeouts branch May 10, 2021 06:55
ahsanbarkati pushed a commit that referenced this pull request May 27, 2021
* fixing query timeouts for graphql queries too

* fixing online restore test

(cherry picked from commit bb0358e)
ahsanbarkati pushed a commit that referenced this pull request May 27, 2021
* fixing query timeouts for graphql queries too

* fixing online restore test

(cherry picked from commit bb0358e)
ahsanbarkati pushed a commit that referenced this pull request Jun 1, 2021
* fixing query timeouts for graphql queries too

* fixing online restore test

(cherry picked from commit bb0358e)
ahsanbarkati added a commit that referenced this pull request Jun 2, 2021
…s too (#7796)

- fixing query timeouts for GraphQL queries too
- fixing online restore test

(cherry picked from commit bb0358e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants