Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): gh-runner.sh refactored to account for ARM architecture #8395

Merged
merged 5 commits into from
Oct 28, 2022
Merged

fix(ci): gh-runner.sh refactored to account for ARM architecture #8395

merged 5 commits into from
Oct 28, 2022

Conversation

adityasadalage
Copy link
Contributor

Problem

gh-runner.sh in contrib folder does not account for different installs in arm architecture

Solution

Adding if condition checks to install the right .tar files in the existing runner script

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Oct 27, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 37.18% when pulling 14c2787 on adityasadalage/support_arm_runners into c6ca6bd on main.

skrdgraph
skrdgraph reviewed Oct 28, 2022
View reviewed changes
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good ... did you test this out by attaching both kinds of runners?

@adityasadalage adityasadalage changed the title gh-runner.sh refactored to account for ARM architecture fix(ci): gh-runner.sh refactored to account for ARM architecture Oct 28, 2022
@skrdgraph skrdgraph self-requested a review October 28, 2022 20:27
@skrdgraph skrdgraph merged commit 79d3492 into main Oct 28, 2022
@skrdgraph skrdgraph deleted the adityasadalage/support_arm_runners branch October 28, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrdgraph skrdgraph skrdgraph approved these changes

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityasadalage @CLAassistant @coveralls @skrdgraph