Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): add test cases for getIPsFromString #8433

Merged
merged 4 commits into from
Dec 7, 2022
Merged

chore(test): add test cases for getIPsFromString #8433

merged 4 commits into from
Dec 7, 2022

Conversation

dshekhar95
Copy link
Contributor

@dshekhar95 dshekhar95 commented Nov 15, 2022 •
edited
Loading

Problem

test cases missing for getIPsFromString

Solution

add test for empty string, error cases

@coveralls
Copy link

coveralls commented Nov 15, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 37.196% when pulling b701f59 on dshekhar95-addIpParsingTests into bc5f584 on main.

@dshekhar95 dshekhar95 changed the title chore(test): add test case for getIPsFromString passing empty string chore(test): add test cases for getIPsFromString Nov 15, 2022
matthewmcneely
matthewmcneely approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@matthewmcneely matthewmcneely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (following the format revert in run_test.go)

@dshekhar95
Update run_test.go
230f5d9 
reverting unintended change
@dshekhar95 dshekhar95 merged commit 228bc09 into main Dec 7, 2022
@dshekhar95 dshekhar95 deleted the dshekhar95-addIpParsingTests branch December 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@MichelDiz MichelDiz MichelDiz approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@gcxml gcxml Awaiting requested review from gcxml

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dshekhar95 @coveralls @matthewmcneely @MichelDiz