Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): Fix after for regexp, match functions (#7700) #8471

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Dec 1, 2022

Match, Compare, Regexp and Geo functions didn't work with after attribute. The PR fixes that.

With this PR, the following type of queries are possible:

{
	q(func: match(name, Ali, 5), after: 0x2710) {
		uid
		name
	}
}

(cherry picked from commit c11a607)

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ anurags92
❌ rohanprasad
You have signed the CLA already but the status is still pending? Let us recheck it.

@all-seeing-code all-seeing-code added the cherry-pick-22.0.2 Label for all cherry-picks for 22.0.2 Release label Dec 1, 2022
@all-seeing-code all-seeing-code marked this pull request as ready for review December 1, 2022 14:28
@coveralls
Copy link

coveralls commented Dec 1, 2022

Coverage Status

Coverage decreased (-0.001%) to 37.172% when pulling f2e8981 on cherry-pick-7700 into 2b1441d on main.

query/query1_test.go Outdated Show resolved Hide resolved
query/query3_test.go Outdated Show resolved Hide resolved
rohanprasad and others added 2 commits December 6, 2022 19:48
* fix(pagination): Fix after for regexp, match functions
* Add test for pagination with other functions

(cherry picked from commit c11a607)
@all-seeing-code all-seeing-code merged commit fdcc7be into main Dec 7, 2022
@all-seeing-code all-seeing-code deleted the cherry-pick-7700 branch December 7, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-22.0.2 Label for all cherry-picks for 22.0.2 Release
Development

Successfully merging this pull request may close these issues.

6 participants