chore(logging): Add more logging and trace tags for debugging #8490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 56cb4c9)
(cherry picked from commit cd78f696fb4e8482a8a3127dd3ab7114c9e46417)
all-seeing-code
requested review from
akon-dey,
gcxml,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
matthewmcneely
approved these changes
Dec 6, 2022
meghalims
approved these changes
Dec 7, 2022
all-seeing-code
added a commit
that referenced
this pull request
Dec 12, 2022
Adds logging and sets query `tag` for improved tracing in Jaeger. Co-authored-by: Damon Feldman <[email protected]> (cherry picked from commit 1e06e81)
|
This enhancement ensures that the duration of all queries are logged if either the -v 3 logging level is set (level 3 is debug) or if "request logging" is enabled on the alpha. In addition, all query errors are logged if logging is set to -v 3. Previously, errors were not logged on the alpha (only reported to the client). Also, for a particular error in zero logs reading "Error while writing: ..." the root cause of the error is now logged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logging and sets query
tagfor improved tracing in Jaeger.