Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(version): bump up dgraph version in source #8499

Closed
wants to merge 3 commits into from
Closed

fix(version): bump up dgraph version in source #8499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da78c42
initial
joshua-goldstein Dec 9, 2022
95dd119
update
joshua-goldstein Dec 9, 2022
e1b39e6
cleanup and add todos
joshua-goldstein Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions worker/backup_ee.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build !oss
// +build !oss

/*
Expand Down Expand Up @@ -214,6 +215,7 @@ func ProcessBackupRequest(ctx context.Context, req *pb.BackupRequest) error {
}
}

// TODO: we should use ldflag in init.go to set this version (currently DgraphVersion hard coded in x.go)
dir := fmt.Sprintf(backupPathFmt, req.UnixTs)
m := Manifest{
ReadTs: req.ReadTs,
Expand Down
3 changes: 2 additions & 1 deletion x/x.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ const (
"X-CSRF-Token, X-Auth-Token, X-Requested-With"
DgraphCostHeader = "Dgraph-TouchedUids"

DgraphVersion = 2103
// TODO: we should use ldflag in init.go (currently not exported) to set this version
DgraphVersion = 2200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add this to the "Doing a Release" doc, basically just making sure this value is correct when the release is cut. But yeah, I agree in principle that it really should be pulling from the environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ^ would it be possible to pull this info from the environment at build time instead?

)

var (
Expand Down