Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the /admin/backup and /admin/export API asynchronous #8554

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Make the /admin/backup and /admin/export API asynchronous #8554

merged 1 commit into from
Jan 23, 2023

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Jan 2, 2023 •
edited
Loading

pull #7781
Part of the change from #7716

We remove the deprecated /admin/{backup,export} APIs have been removed, since this change would have broken their APIs anyway.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mangalaman93 mangalaman93 added the slash-to-main PRs which bring slash branch on par with main. label Jan 2, 2023
@matthewmcneely
Copy link
Contributor

Hey @mangalaman93 I see multiple branches being requested into your cp branch? Is this intentional? I think @meghalims wanted each CP into its own separate branch. Maybe there are dependencies on prior branches that I'm not grokking, just wanted to check.

@mangalaman93 mangalaman93 force-pushed the aman/async branch 3 times, most recently from 992ef57 to 308f496 Compare January 3, 2023 11:51
@mangalaman93 mangalaman93 force-pushed the aman/async branch 2 times, most recently from 96cb23c to 965f318 Compare January 3, 2023 14:43
@mangalaman93
Copy link
Contributor Author

yeah, it is because of the dependency. Once the dependent branch is merged, GitHub will automatically change the base branch to main

@joshua-goldstein
Copy link
Contributor

Looks like original PR went into master in #7716 and it was brought into slash in #7781

@mangalaman93 mangalaman93 changed the title bring in the asynchronous tasks implementation Make the /admin/backup and /admin/export API asynchronous Jan 5, 2023
matthewmcneely
matthewmcneely previously approved these changes Jan 9, 2023
View reviewed changes
@mangalaman93 mangalaman93 added this to the v23.0.0 milestone Jan 11, 2023
Base automatically changed from aman/cp to main January 18, 2023 20:01
@coveralls
Copy link

coveralls commented Jan 18, 2023 •
edited
Loading

Coverage Status

Coverage: 66.825% (+0.05%) from 66.77% when pulling 45a5ec1 on aman/async into cbec230 on main.

@ajeetdsouza @mangalaman93
fix(task): make /admin{export, backup} endpoints async
45a5ec1 
This commit also removes the /admin/export and /admin/backup
endpoints for creating export and backup respectively.

This also removes the exportedFiles field (#7835) (#7836)
@all-seeing-code all-seeing-code merged commit d3bf7b7 into main Jan 23, 2023
@all-seeing-code all-seeing-code deleted the aman/async branch January 23, 2023 11:47
mangalaman93 added a commit to dgraph-io/dgraph-docs that referenced this pull request May 23, 2023
@mangalaman93
remove reference to /admin/{backup,export} endpoints
a4cb437 
The PR dgraph-io/dgraph#8554
removes these two endpoints.
@mangalaman93 mangalaman93 mentioned this pull request May 23, 2023
Merged
mangalaman93 added a commit to dgraph-io/dgraph-docs that referenced this pull request Aug 3, 2023
@mangalaman93
remove reference to /admin/{backup,export} endpoints (#586)
b765348 
The PR dgraph-io/dgraph#8554 removes these two
endpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@harshil-goel harshil-goel harshil-goel approved these changes

@matthewmcneely matthewmcneely matthewmcneely left review comments

@akon-dey akon-dey Awaiting requested review from akon-dey

@MichelDiz MichelDiz Awaiting requested review from MichelDiz

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
slash-to-main PRs which bring slash branch on par with main.
Milestone
v23.0.0
Development

Successfully merging this pull request may close these issues.
8 participants
@mangalaman93 @CLAassistant @matthewmcneely @joshua-goldstein @coveralls @all-seeing-code @harshil-goel @ajeetdsouza