-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt(schema): Load schema and types using Stream framework #8562
Conversation
|
6adb355
to
0a7c7f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a question.
I feel like the stream framework api is a bit weird. Like we should be just passing the KeyToList function in the object creation itself? What do you think, maybe we should take a look at all the apis that badger has exposed.
) For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad)
0a7c7f2
to
6d9c83e
Compare
For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization.
(cherry picked from commit d03d5ad)