Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): adjust cron schedules #8592

Merged
merged 2 commits into from
Jan 7, 2023
Merged

fix(ci): adjust cron schedules #8592

merged 2 commits into from
Jan 7, 2023

Conversation

skrdgraph
Copy link
Contributor

Problem

Our scheduled runs happen too often. We now have a stable baseline - and we can limit these runs. We are also adjusting triggering evented runs when a PR is opened, and when a PR is merged*. Reducing the scheduled run makes more sense now.

Solution

changing these runs to happen twice daily

@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Jan 6, 2023
@skrdgraph skrdgraph marked this pull request as ready for review January 6, 2023 22:23
Copy link
Contributor

@kevinmingtarja kevinmingtarja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coveralls
Copy link

Coverage Status

Coverage: 64.365% (+0.02%) from 64.342% when pulling 99b905d on skrdgraph/cron_schedules into d09d679 on main.

Copy link
Contributor

@adityasadalage adityasadalage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skrdgraph skrdgraph merged commit 9e4b288 into main Jan 7, 2023
@skrdgraph skrdgraph deleted the skrdgraph/cron_schedules branch January 7, 2023 01:15
skrdgraph added a commit that referenced this pull request Feb 24, 2023
## Problem
Need more test runs because we are closing in on our next release

## Solution
Increase frequency for critical CI runs to happen every 2hrs
This will increase our CI spends, but it's better we keep this running
for a few days to detect any failures.

**note** 
- we are doing this because we noticed some flaky failures in our tests
on `main` (*`scheduled runs`*)
- the last change was on jan-6
#8592, where we reduced the
frequency because of a stable baseline
@MichelDiz MichelDiz added the dgraph Issue or PR created by an internal Dgraph contributor. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Related to integrations with other projects. dgraph Issue or PR created by an internal Dgraph contributor.
Development

Successfully merging this pull request may close these issues.

5 participants