Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linter): fix some of the warnings from gas linter #8664

Merged
merged 1 commit into from
Feb 15, 2023
Merged

chore(linter): fix some of the warnings from gas linter #8664

merged 1 commit into from
Feb 15, 2023

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Feb 13, 2023 •
edited
Loading

@all-seeing-code
Copy link
Contributor

@mangalaman93 Can you add what's gas linter (probably a link as well)?

@mangalaman93 mangalaman93 force-pushed the aman/line120 branch 2 times, most recently from d7484b1 to a662e0d Compare February 14, 2023 07:14
Base automatically changed from aman/line120 to main February 14, 2023 17:58
@skrdgraph
Copy link
Contributor

@mangalaman93 Can you add what's gas linter (probably a link as well)?

gas is a security linter.

@anurags92 this explains all linters https://golangci-lint.run/usage/linters/ (I recommend spending about 15mins doing a high level reading) & compare with our golangci yaml

Also this was something I had bookmarked https://github.com/golangci/awesome-go-linters (may have deprecated linters).

skrdgraph
skrdgraph previously approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@skrdgraph skrdgraph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage upload failed, there was probably a glitch in network or an issue on coveralls. The test will need a re-trigger.

I also think this will be interesting to observe our logs on v23.

@mangalaman93
Copy link
Contributor Author

Thanks Sudhish, yeah, will need to keep an eye out. I didn't see anything interesting during my testing locally on the laptop.

@coveralls
Copy link

coveralls commented Feb 15, 2023 •
edited
Loading

Coverage Status

Coverage: 67.333% (+0.5%) from 66.825% when pulling 981e99d on aman/gas into 71b957e on main.

@mangalaman93 mangalaman93 reopened this Feb 15, 2023
@mangalaman93 mangalaman93 merged commit b85ff4e into main Feb 15, 2023
@mangalaman93 mangalaman93 deleted the aman/gas branch February 15, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@harshil-goel harshil-goel harshil-goel approved these changes

@skrdgraph skrdgraph skrdgraph left review comments

@akon-dey akon-dey Awaiting requested review from akon-dey

@MichelDiz MichelDiz Awaiting requested review from MichelDiz

@matthewmcneely matthewmcneely Awaiting requested review from matthewmcneely

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mangalaman93 @all-seeing-code @skrdgraph @coveralls @harshil-goel