Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dgo to v230 #8785

Merged
merged 1 commit into from
May 11, 2023
Merged

upgrade dgo to v230 #8785

merged 1 commit into from
May 11, 2023

Conversation

mangalaman93
Copy link
Contributor

@mangalaman93 mangalaman93 commented Apr 4, 2023

This version of dgo improves the DialCloud function and deprecates DialSlashEndpoint and DialSlashGraphQLEndpoint. It also starts to use go 1.19 now.

@dgraph-bot dgraph-bot added area/bulk-loader Issues related to bulk loading. area/core internal mechanisms area/enterprise Related to proprietary features area/enterprise/acl Related to Access Control Lists area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/live-loader Issues related to live loading. area/querylang Issues related to the query language specification and implementation. area/testing Testing related issues go Pull requests that update Go code labels Apr 4, 2023
MichelDiz
MichelDiz previously approved these changes Apr 5, 2023
@skrdgraph
Copy link
Contributor

looks good ... add a description to provide some context. The context is getting missed by relying on the PR titles. This one is straightforward (we understand it). But adding a small description explaining the changes or pointing to changelog of v230 may be a good line item to add to this description.

@mangalaman93
Copy link
Contributor Author

looks good ... add a description to provide some context. The context is getting missed by relying on the PR titles. This one is straightforward (we understand it). But adding a small description explaining the changes or pointing to changelog of v230 may be a good line item to add to this description.

good idea. I wasn't sure what to add to the description. Added now.

harshil-goel
harshil-goel previously approved these changes May 8, 2023
@mangalaman93 mangalaman93 merged commit 3fa1376 into main May 11, 2023
@mangalaman93 mangalaman93 deleted the aman/dgo branch May 11, 2023 05:47
dgraph-bot pushed a commit that referenced this pull request Jul 7, 2023
This version of dgo improves the `DialCloud` function and deprecates
`DialSlashEndpoint` and `DialSlashGraphQLEndpoint`. It also starts to
use go 1.19 now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bulk-loader Issues related to bulk loading. area/core internal mechanisms area/enterprise/acl Related to Access Control Lists area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/live-loader Issues related to live loading. area/querylang Issues related to the query language specification and implementation. area/testing Testing related issues go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

6 participants