fix(bulk): removed buffer max size #8841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davideaimar
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
dgraph-bot
added
area/bulk-loader
mangalaman93
approved these changes
May 26, 2023
joshua-goldstein
approved these changes
May 29, 2023
dgraph-bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
## Problem
On huge datasets, bulk import crashes with this stack trace:
```
panic: z.Buffer max size exceeded: 68719476736 offset: 68719476718 grow: 51
goroutine 421 [running]:
github.com/dgraph-io/ristretto/z.(*Buffer).Grow(0xc050d17c00, 0x33)
/home/runner/go/pkg/mod/github.com/dgraph-io/[email protected]/z/buffer.go:180 +0x55b
github.com/dgraph-io/ristretto/z.(*Buffer).SliceAllocate(0xc050d17c00, 0x2f)
/home/runner/go/pkg/mod/github.com/dgraph-io/[email protected]/z/buffer.go:266 +0x2e
github.com/dgraph-io/dgraph/dgraph/cmd/bulk.(*mapIterator).Next(0xc00e56f410, 0x3?, {0xc034740c40, 0x1d, 0x20})
/home/runner/work/dgraph/dgraph/dgraph/cmd/bulk/reduce.go:206 +0x126
github.com/dgraph-io/dgraph/dgraph/cmd/bulk.(*reducer).reduce.func2()
/home/runner/work/dgraph/dgraph/dgraph/cmd/bulk/reduce.go:486 +0x5aa
created by github.com/dgraph-io/dgraph/dgraph/cmd/bulk.(*reducer).reduce
/home/runner/work/dgraph/dgraph/dgraph/cmd/bulk/reduce.go:476 +0x452
```
## Solution
Removing hard limit of 64GB to buffer sizes avoided panic and
successfully completed the import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On huge datasets, bulk import crashes with this stack trace:
Solution
Removing hard limit of 64GB to buffer sizes avoided panic and successfully completed the import.