chore(build): name codename configurable #8951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code and
billprovince
as code owners
| @@ -15,7 +15,7 @@ | |||
| # | |||
|
|
|||
| BUILD ?= $(shell git rev-parse --short HEAD) | |||
| BUILD_CODENAME = dgraph | |||
| BUILD_CODENAME ?= dgraph | |||
There was a problem hiding this comment.
BUILD_CODENAME also defined in the dgraph/Makefile. Which one takes precedence?
There was a problem hiding this comment.
We define BUILD_CODENAME ?= dgraph in the nested makefile, which means that, if BUILD_CODENAME is defined at the root level, it will take precedence and be inherited at the lower level. I've also confirmed this locally just to be sure.
sanjayk-github-dev
approved these changes
Aug 16, 2023
mangalaman93
approved these changes
Aug 16, 2023
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
currently codename ldflag is not mutable and set to `dgraph`. We would like to make it configurable for cloud builds.
jbhamra1
pushed a commit
that referenced
this pull request
Aug 17, 2023
currently codename ldflag is not mutable and set to `dgraph`. We would like to make it configurable for cloud builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Currently
codenameldflagis not mutable and set todgraph`. We would like to make it configurable for cloud builds.