Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: luarocks support #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: luarocks support #8

wants to merge 1 commit into from

Conversation

mrcjkb
Copy link

@mrcjkb mrcjkb commented Jan 22, 2024

Hey 👋

I noticed this plugin has some dependencies that are on luarocks...

Summary

This PR is part of a push to get neovim plugins on LuaRocks.

Things done:

  • Add a release-please workflow that creates release PRs with SemVer versioning based on conventional commits.
  • Add a workflow that publishes tags to LuaRocks when a tag or release is pushed.

The workflows are based on this guide by @vhyrro.

Notes:

  • On each merge to main, the release-please workflow creates (or updates an existing) release PR.
  • You decide when to merge release PRs.
    Doing so will result in a SemVer tag, and a GitHub release, which will trigger the luarocks workflow.
  • Tagged releases are installed locally and then published to luarocks.org.
    On PRs, a test release is installed, but not published.
  • For the luarocks workflow to work, someone with a luarocks.org account will have to add their API key to this repo's GitHub actions secrets.
  • Due to a shortcoming in LuaRocks (label doesn't get picked up from rockspec luarocks/luarocks-site#188), the neovim and/or vim labels have to be added to the LuaRocks package manually (after the first upload), for this plugin to show up in https://luarocks.org/labels/neovim or https://luarocks.org/labels/vim, respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant