Skip to content

Commit

Permalink
MINOR: [C++][Docs] Add \deprecated tag to deprecated BufferReader con…
Browse files Browse the repository at this point in the history
…structor (apache#38721)

### Rationale for this change

The PR [apacheGH-37360](apache#37360) for issue [apacheGH-37212](apache#37212) deprecated three BufferReader constructors and I noticed one of them was missing a `\deprecated` command.

### What changes are included in this PR?

This adds a `\deprecated` command one of the deprecated constructors with a message. The other two didn't need it because they weren't already documented. i.e., they weren't listed under https://arrow.apache.org/docs/cpp/api/io.html so documenting them at this point just to add `\deprecated` wouldn't make sense.

### Are these changes tested?

No, this is a simple docs change.

### Are there any user-facing changes?

Yes, this adds a notice to the docs for this particular method.

Authored-by: Bryce Mecum <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
  • Loading branch information
amoeba authored and dgreiss committed Feb 17, 2024
1 parent b1ab60d commit c113973
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cpp/src/arrow/io/memory.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ class ARROW_EXPORT BufferReader
BufferReader(const uint8_t* data, int64_t size);

/// \brief Instantiate from std::string_view. Does not own data
/// \deprecated Deprecated in 14.0.0. Use FromString or
/// BufferReader(std::shared_ptr<Buffer> buffer) instead.
ARROW_DEPRECATED(
"Deprecated in 14.0.0. Use FromString or BufferReader(std::shared_ptr<Buffer> "
"buffer) instead.")
Expand Down

0 comments on commit c113973

Please sign in to comment.