New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

51 #78

Merged

dgroup merged 5 commits into dgroup:master from daniilBondarenk:51

Feb 12, 2022

Contributor

daniilBondarenk commented Feb 10, 2022

daniilBondarenk and others added 3 commits

February 10, 2022 09:58


          dgroup#51: Basic implementation

02cc8ac


          dgroup#51: Basic implementation

93291dc


          dgroup#51: Merge with master

9464c15

codecov bot commented Feb 10, 2022 •

edited

Loading

Codecov Report

Merging #78 (e6f1445) into master (53af574) will decrease coverage by 3.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   67.61%   63.63%   -3.98%     
==========================================
  Files           8        8              
  Lines         176      176              
==========================================
- Hits          119      112       -7     
- Misses         57       64       +7

Impacted Files	Coverage Δ
g2w/api.py	`76.47% <0.00%> (-23.53%)`	⬇️
g2w/ws.py	`54.16% <0.00%> (-6.25%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53af574...e6f1445. Read the comment docs.

dgroup approved these changes

View reviewed changes

dgroup reviewed

View reviewed changes

g2w/__init__.py Outdated

               from .grafana import Alert
               from .version import __version__
               from .ws import Ws
               from .log import Log
-              __all__ = ["Push", "Ws", "LoggableRoute", "Alert", "Log", __version__]
+              __all__ = ["Push", "Ws", "LoggableRoute", "Alert", "commit_msg_pattern", "Log", __version__]

Owner

dgroup Feb 10, 2022

@daniilBondarenk build failed due to

g2w/__init__.py:9:80: E501 line too long (92 > 79 characters)

Please format __init__.py properly

dgroup requested changes

View reviewed changes

Owner

dgroup left a comment

init.py should be formatted properly

danbond02 added 2 commits

February 12, 2022 10:00


          Merge branch 'master' into 51

61e990c

# Conflicts:
#	g2w/__init__.py
#	g2w/gitlab.py
#	tests/test_gitlab.py


          Merge branch 'master' into 51

e6f1445

# Conflicts:
#	tests/test_gitlab.py

sonarcloud bot commented Feb 12, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

dgroup approved these changes

View reviewed changes

dgroup merged commit 932edc9 into dgroup:master

dgroup added this to the 0.3.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet