Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.9 support #243

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Add Python 3.9 support #243

merged 1 commit into from
Nov 8, 2020

Conversation

dgrunwald
Copy link
Owner

As usual with new Python releases, I diffed the 3.8.0 Python headers against the 3.9.0 Python headers and manually made these adjustments to python3-sys.

While rust-cpython could be compiled against Python 3.9 without these changes, there were some breaking changes to the headers:

  • some macros like PyObject_IS_GC or PyObject_GET_WEAKREFS_LISTPTR were replaced with functions
  • some functions were removed from the API
  • PyConfig had breaking changes to the struct layout

@markbt
Copy link
Collaborator

markbt commented Oct 22, 2020

I haven't compared with the Python headers, but it all looks reasonable to me.

The Travis CI is failing because Python 3.9 isn't available there yet. Is this likely to become available soon, or are we going to need to do something else?

@dgrunwald
Copy link
Owner Author

No idea when travis will add 3.9. See https://travis-ci.community/t/python-3-9-0-build/10091/10
We could switch to 3.9-dev in the meantime, though I'm not sure which version exactly we'd be getting there.

@dgrunwald
Copy link
Owner Author

I've reported the ICE with nightly rust at rust-lang/rust#78398

I diffed the 3.8.0 Python headers against the 3.9.0 Python headers and manually made these adjustments to python3-sys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants