VxLAN Tunnel Counters and Rates implementation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Venkat Garigipati <[email protected]>
…lobal context index. (sonic-net#832)" (sonic-net#859) This reverts commit 0e2105a. multi-asic VS with multiple swss and syncd dockers, comes up without context_config.json or hwinfo. Just like a single asic vs, multi-asic vs will spawn multiple instances of swss and syncd with default hwinfo. Reverting this PR as it is not required currently for multi-asic VS.
Will help using multiple switches in VS with multiple contextes.
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
…onic-net#865) Signed-off-by: kcudnik <[email protected]>
…ilation instead of qemu emulation (sonic-net#852) Current armhf Sonic build on amd64 host uses qemu emulation. Due to the nature of the emulation it takes a very long time, about 22-24 hours to complete the build. The change I did to improve the building time ports Sonic armhf build on amd64 host for Marvell platform for debian buster to use cross-compilation on arm64 host for armhf target. The overall Sonic armhf building time using cross-compilation is about 6 hours. The Sonic configure and build for the armhf cross-compilation is as following: NOJESSIE=1 NOSTRETCH=1 BLDENV=buster CROSS_BLDENV=1 make configure PLATFORM=marvell-armhf PLATFORM_ARCH=armhf NOJESSIE=1 NOSTRETCH=1 BLDENV=buster CROSS_BLDENV=1 make target/sonic-marvell-armhf.bin Sonic module should check if $CROSS_BUILD_ENVIRON is 'y' to make sure that it is cross-compilation build.
syncd/FlexCounter.cpp
Outdated
|
|
||
| std::vector<uint64_t> tunnelStats(tunnelCounterIds.size()); | ||
|
|
||
| // Get rif stats |
There was a problem hiding this comment.
I think here is a typo, should be tunnel but not rif
syncd/FlexCounter.cpp
Outdated
| } | ||
|
|
||
| uint64_t value; | ||
| for (int cntr_id = SAI_TUNNEL_STAT_IN_OCTETS; cntr_id <= SAI_TUNNEL_STAT_OUT_PACKETS; ++cntr_id) |
There was a problem hiding this comment.
Is it possible to pass counterIds vector to this update function and iterate through it here instead of using hardcoded values?
Otherwise, if values here are hardcoded, it could cause some issues in case number of tunnel counters change.
For example it is done like that in updateSupportedQueueCounters() function.
Signed-off-by: kcudnik <[email protected]>
…-net#869) Start recording CRS operations response to sairedis.rec but only when response is not success.
Signed-off-by: Wenda Ni <[email protected]>
volodymyrsamotiy
approved these changes
Aug 3, 2021
Use new api to record hardware info when creating switch for easy read. Since hardware info attribute type is s8list, it will be serialized as array of integers, so to actually improve readability of actual value, put it as comment in recording file.
When watchdog thread will exceed 30sec it will print currently executing event like create/remove/get/set. This data can be also found in sairedis.rec, but this PR will also print this in syslog for convenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flexcounter implementation for vxlan tunnel counters and rates implementation