Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MustCombineARecord error message for // #1702

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Mar 10, 2020

For {=} // 1, we would previously report:

You tried to combine the following value:

↳ {=}

... which is not a record, but is actually a:

↳ 1

Now we report:

You tried to combine the following value:

↳ 1

... which is not a record, but is actually a:

↳ Natural

Fixes #1701.

For `{=} // 1`, we would previously report:

    You tried to combine the following value:

    ↳ {=}

    ... which is not a record, but is actually a:

    ↳ 1

Now we report:

    You tried to combine the following value:

    ↳ 1

    ... which is not a record, but is actually a:

    ↳ Natural

Fixes #1701.
@sjakobi sjakobi force-pushed the sjakobi/1701-fix-combine-error branch from 0a765fb to b276a20 Compare March 10, 2020 14:54
@sjakobi
Copy link
Collaborator Author

sjakobi commented Mar 10, 2020

I basically copied this patch from the error handling for /\, which already supplied the correct arguments to MustCombineARecord.

This was referenced Mar 10, 2020
@mergify mergify bot merged commit f56bb0e into master Mar 10, 2020
@mergify mergify bot deleted the sjakobi/1701-fix-combine-error branch March 10, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad long-form error "You can only combine records"
2 participants