Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Determine information about merged cells #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tgallei
Copy link

@tgallei tgallei commented Aug 22, 2023

Possibility to check whether it is a merged cell and to determine the cell in which the data is stored in a merged cell.

Logic makes it easier to read out the values for merged cells, as the value is only stored in the upper left cell.

@tgallei tgallei changed the title Determine information about merged cells Feature: Determine information about merged cells Aug 22, 2023
@ochedru ochedru self-requested a review November 10, 2023 18:38
Copy link
Collaborator

@ochedru ochedru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this does not introduce any performance regression.

mergedCellAddress = new CellAddress(mergedCell.getFirstRow(), mergedCell.getFirstColumn());
break;
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid this could introduce a huge performance regression if there are many merged cell ranges, Maybe we could organize them in an ordered data structure to speed up this search? For an example, see #236.

@alexander793
Copy link

Is there any update on this? I would love to have a feature to extract the value of merged regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants