Leverage HTMX to semplify rendering of Circuit Termination Form

Associated with issue netbox-community#11891

netbox/circuits/choices.py

@@ -70,3 +70,13 @@ class CircuitTerminationPortSpeedChoices(ChoiceSet):
         (1544, 'T1 (1.544 Mbps)'),
         (2048, 'E1 (2.048 Mbps)'),
     ]
+
+
+class CircuitTerminationTypeChoices(ChoiceSet):
+    SITE = 'site'
+    PROVIDER_NETWORK = 'provider_network'
+
+    CHOICES = [
+        (SITE, 'Site'),
+        (PROVIDER_NETWORK, 'Provider Network'),
+    ]

netbox/circuits/forms/model_forms.py

@@ -1,13 +1,15 @@
+from django import forms
 from django.utils.translation import gettext as _
 
-from circuits.choices import CircuitCommitRateChoices, CircuitTerminationPortSpeedChoices
+from circuits.choices import CircuitCommitRateChoices, CircuitTerminationPortSpeedChoices, CircuitTerminationTypeChoices
 from circuits.models import *
 from dcim.models import Site
 from ipam.models import ASN
 from netbox.forms import NetBoxModelForm
 from tenancy.forms import TenancyForm
 from utilities.forms.fields import CommentField, DynamicModelChoiceField, DynamicModelMultipleChoiceField, SlugField
-from utilities.forms.widgets import DatePicker, NumberWithOptions
+from utilities.forms.utils import get_field_value
+from utilities.forms.widgets import DatePicker, HTMXSelect, NumberWithOptions
 
 __all__ = (
     'CircuitForm',
@@ -139,11 +141,21 @@ class CircuitTerminationForm(NetBoxModelForm):
         selector=True
     )
 
+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+
+        termination_type = get_field_value(self, 'termination_type')
+
+        if termination_type != CircuitTerminationTypeChoices.SITE:
+            del self.fields['site']
+        if termination_type != CircuitTerminationTypeChoices.PROVIDER_NETWORK:
+            del self.fields['provider_network']
+
     class Meta:
         model = CircuitTermination
         fields = [
-            'circuit', 'term_side', 'site', 'provider_network', 'mark_connected', 'port_speed', 'upstream_speed',
-            'xconnect_id', 'pp_info', 'description', 'tags',
+            'circuit', 'term_side', 'termination_type', 'site', 'provider_network', 'mark_connected', 'port_speed',
+            'upstream_speed', 'xconnect_id', 'pp_info', 'description', 'tags',
         ]
         widgets = {
             'port_speed': NumberWithOptions(
@@ -152,4 +164,8 @@ class Meta:
             'upstream_speed': NumberWithOptions(
                 options=CircuitTerminationPortSpeedChoices
             ),
+            'termination_type': HTMXSelect(),
+        }
+        labels = {
+            'termination_type': 'Termination Type',
         }

netbox/circuits/migrations/0043_circuittermination_termination_type.py

@@ -0,0 +1,18 @@
+# Generated by Django 4.1.9 on 2023-05-22 04:54
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('circuits', '0042_provideraccount'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='circuittermination',
+            name='termination_type',
+            field=models.CharField(default='site', max_length=50),
+        ),
+    ]

netbox/circuits/models/circuits.py

@@ -164,6 +164,11 @@ class CircuitTermination(
         choices=CircuitTerminationSideChoices,
         verbose_name='Termination'
     )
+    termination_type = models.CharField(
+        max_length=50,
+        choices=CircuitTerminationTypeChoices,
+        default=CircuitTerminationTypeChoices.SITE
+    )
     site = models.ForeignKey(
         to='dcim.Site',
         on_delete=models.PROTECT,

netbox/circuits/views.py

@@ -412,7 +412,6 @@ class CircuitContactsView(ObjectContactsView):
 class CircuitTerminationEditView(generic.ObjectEditView):
     queryset = CircuitTermination.objects.all()
     form = forms.CircuitTerminationForm
-    template_name = 'circuits/circuittermination_edit.html'
 
 
 @register_model_view(CircuitTermination, 'delete')