-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requiring pre-build libbezier
when building bezier._speedup
Python binary extension
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular: - Splitting into two jobs `libbezier-debug` and `libbezier-release` - Factoring out a `_cmake` helper function that can be used both by the `libbezier-*` sessions and by other sessions that want to depend on `libbezier` - Adding helper to create a nox directory, e.g. `.nox/libbezier-debug` if it is needed by a session that depends on a `libbezier-*` having already been run
This now **fully** removes the Python components used to build the Fortran library / ABI. (This is a good thing.)
Also (temporarily) deleting content from `docs/python/binary-extension` about "pieces" of `libbezier` that were previously included with the Python package (but now will be removed) - `lib/bezier.lib` - `include/` - `lib/libbezier.a` Also removed comments about `extra-dll/`. This content needs to move in `docs/abi/index.rst` and possibly a new file in `docs/abi/`.
Also (attempting to) make sure `cmake` is pre-installed on all platforms before running tests.
The `cmake` dep has been added to the image and pushed to Docker Hub.
In the process, updating the `expected_journal.txt` files for each CI platform (or intentionally making them invalid). Temporarily putting the "check_journal" sessions first in all CI runs.
I mistakenly used 3.7 (instead of 3.8) as the Python version in the `check_journal` session (was testing locally where I don't have 3.8 official install from `python.org`).
Still running `check_journal` **FIRST** on AppVeyor to verify 3.8 (vs. 3.7). [travis skip]
I am leaning towards merging this as-is, but want to sleep on it because there are a few remaining things to "clean up" after this:
|
Also ditching `os.chdir()` in situations where `cwd=...` will suffice in `subprocess` invocations.
I was unsure if it the `.lib` file needed to be side-by-side with the `bezier.dll` file, but am now clear it does not after https://ci.appveyor.com/project/dhermes/bezier/builds/30201063.
This was referenced Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process, splitting the
nox -s cmake
session into twonox -s libbezier-*
sessions that are re-usable (and get used by many of the sessions that rely onlibbezier
).Towards #62.