Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing Curve.evaluate_hodograph() as part of the public API. #191

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

dhermes
Copy link
Owner

@dhermes dhermes commented Jan 26, 2020

Fixes #138.

However, this just exposes a subroutine / procedure from the ABI. A "complete" implementation would include an equivalent Curve.evaluate_hodograph_multi().

@@ -276,6 +276,38 @@ def evaluate_multi(self, s_vals):
"""
return _curve_helpers.evaluate_multi(self._nodes, s_vals)

def evaluate_hodograph(self, s):
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @anntzer

I am (for now) just exposing the method that already exists. There is no equivalent evaluate_hodograph_multi().

Somewhat related to this is #87.

@dhermes
Copy link
Owner Author

dhermes commented Jan 27, 2020

@anntzer I'm not when the next release will be, but I can try to make one this week if you'd like.

Fixes #138.

However, this just exposes a subroutine / procedure from
the ABI. A "complete" implementation would include an equivalent
`Curve.evaluate_hodograph_multi()`.
@anntzer
Copy link
Contributor

anntzer commented Jan 27, 2020

Thanks! A new release would be appreciated, but it's not urgent either -- whatever works for you.

@dhermes
Copy link
Owner Author

dhermes commented Feb 4, 2020

FYI @anntzer the 2020.2.3 just came out. It is in many ways a very big release because it's the first release where the libbezier bits are completely foreign to the Python build system (now built via CMake). 🤞 nothing unexpected happens

@anntzer
Copy link
Contributor

anntzer commented Feb 4, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose evaluate_hodograph in Python public API
2 participants