Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs/python/binary-extension.rst to refer to bezier.libs. #211

Merged
merged 7 commits into from
Apr 8, 2020

Conversation

dhermes
Copy link
Owner

@dhermes dhermes commented Apr 6, 2020

@dhermes
Copy link
Owner Author

dhermes commented Apr 6, 2020

(This is quit a sad state of affairs that I don't have easy access to a physical Linux machine, though I now realize I can emulate this test environment from macOS via Docker.)

@dhermes
Copy link
Owner Author

dhermes commented Apr 6, 2020

OK I ran this locally and have presumably found some kind of bug:

$ unzip bezier-2020.2.4.dev1-cp38-cp38-manylinux2010_x86_64.whl 
Archive:  bezier-2020.2.4.dev1-cp38-cp38-manylinux2010_x86_64.whl
  inflating: bezier-2020.2.4.dev1.dist-info/top_level.txt  
...
  inflating: bezier/hazmat/helpers.py  
  inflating: bezier.libs/libbezier-28a97ca3.so.2020.2.3  
  inflating: bezier.libs/libz-eb09ad1d.so.1.2.3  
  inflating: bezier.libs/libquadmath-2d0c479f.so.0.0.0  
  inflating: bezier.libs/libgfortran-2e0d59d6.so.5.0.0 

and from within the dhermes/bezier:latest container

root@892578e06ae2:/var/code/bezier/scripts/manylinux/fixed_wheels# readelf -d bezier/_speedup.cpython-38-x86_64-linux-gnu.so 

Dynamic section at offset 0x43e000 contains 27 entries:
  Tag        Type                         Name/Value
 0x000000000000000f (RPATH)              Library rpath: [$ORIGIN/../bezier.libs]
 0x0000000000000001 (NEEDED)             Shared library: [libbezier-28a97ca3.so.2020.2.3]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
...

@dhermes
Copy link
Owner Author

dhermes commented Apr 6, 2020

Looking at a fresh install of auditwheel, the versions installed are

auditwheel==3.1.0 (released January 29, 2020)
pyelftools==0.26 (released December 5, 2019)
wheel==0.34.1 (released January 30, 2020)

and don't SEEM like they would be cause for a change from bezier/.libs to bezier.libs. (Given that this builds passed at points in the month of February.)

@dhermes dhermes changed the title Adding bogus line to debug Linux doctest failure. Update docs/python/binary-extension.rst to refer to bezier.libs. Apr 8, 2020
@dhermes
Copy link
Owner Author

dhermes commented Apr 8, 2020

OK I was WRONG (big surprise). From the auditwheel release notes (https://github.com/pypa/auditwheel/releases/tag/3.1.0) there was a big change (pypa/auditwheel#90) to use ${SITE_PACKAGES}/bezier.libs instead of ${SITE_PACKAGES}/bezier/.libs.

@dhermes dhermes mentioned this pull request Apr 8, 2020
@dhermes dhermes merged commit e450fbf into master Apr 8, 2020
@dhermes dhermes deleted the debug-1745-failure branch April 8, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant