Alpha argument added to BezierTriangle and CurvedPolygon plotting functions #296
Conversation
src/python/bezier/_plot_helpers.py
Outdated
| @@ -62,14 +62,15 @@ def add_plot_boundary(ax, padding=0.125): | |||
| ) | |||
|
|
|||
|
|
|||
| def add_patch(ax, color, pts_per_edge, *edges): | |||
| def add_patch(ax, color, pts_per_edge, *edges, alpha=None): | |||
There was a problem hiding this comment.
This should just be
| def add_patch(ax, color, pts_per_edge, *edges, alpha=None): | |
| def add_patch(ax, color, pts_per_edge, *edges, alpha=0.625): |
based on the usage below, right?
There was a problem hiding this comment.
Looking at the rest of the changes, I think it's fine to default to alpha=0.625 everywhere.
Though I appreciate why you went with alpha=None as the API choice.
There was a problem hiding this comment.
Np, I'll switch over to 0.625 then
src/python/bezier/_plot_helpers.py
Outdated
| """Add a polygonal surface patch to a plot. | ||
|
|
||
| Args: | ||
| ax (matplotlib.artist.Artist): A matplotlib axis. | ||
| color (Tuple[float, float, float]): Color as RGB profile. | ||
| pts_per_edge (int): Number of points to use in polygonal | ||
| approximation of edge. | ||
| alpha (Optional[float]): Alpha value of patch centre, between 0 and 1 inclusive. |
There was a problem hiding this comment.
| alpha (Optional[float]): Alpha value of patch centre, between 0 and 1 inclusive. | |
| alpha (Optional[float]): Alpha value of patch center, between 0 and 1 inclusive. |
American spelling? For consistency?
There was a problem hiding this comment.
Ah yep, thanks!
I'm an aussie, so that spelling was mostly muscle memory for me
src/python/bezier/curved_polygon.py
Outdated
| """Plot the current curved polygon. | ||
|
|
||
| Args: | ||
| pts_per_edge (int): Number of points to plot per curved edge. | ||
| color (Optional[Tuple[float, float, float]]): Color as RGB profile. | ||
| ax (Optional[matplotlib.artist.Artist]): matplotlib axis object | ||
| to add plot to. | ||
| alpha (Optional[float]): Alpha value of patch centre, between 0 and 1 inclusive. |
There was a problem hiding this comment.
| alpha (Optional[float]): Alpha value of patch centre, between 0 and 1 inclusive. | |
| alpha (Optional[float]): Alpha value of patch center, between 0 and 1 inclusive. |
There was a problem hiding this comment.
I'll get this one too, thanks!
src/python/bezier/_plot_helpers.py
Outdated
| @@ -62,14 +62,15 @@ def add_plot_boundary(ax, padding=0.125): | |||
| ) | |||
|
|
|||
|
|
|||
| def add_patch(ax, color, pts_per_edge, *edges): | |||
| def add_patch(ax, color, pts_per_edge, *edges, alpha=None): | |||
There was a problem hiding this comment.
Looking at the rest of the changes, I think it's fine to default to alpha=0.625 everywhere.
Though I appreciate why you went with alpha=None as the API choice.
|
I think I've got all your comments, best of luck and thanks for the library, I've been finding it super helpful! |
|
The lint failures are "my fault" (just dependencies changing since the repo was last updated) and we can merge with them failing. |
No description provided.